fix: avoid login flag for csh shells#12426
Open
mturac wants to merge 2 commits into
Open
Conversation
dosubot
Bot
added
the
size:M
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="core/tools/implementations/runTerminalCommand.vitest.ts">
<violation number="1" location="core/tools/implementations/runTerminalCommand.vitest.ts:861">
P2: Unix-specific test added without platform guard; will fail on Windows runners</violation>
<violation number="2" location="core/tools/implementations/runTerminalCommand.vitest.ts:869">
P2: Global env cleanup is incorrect when original `SHELL` is undefined; assigning `undefined` to `process.env.SHELL` stringifies it to `'undefined'`, potentially leaking a truthy env value into later tests. Use a conditional restore matching the pattern already used in this file for `HOME` and `USERPROFILE` cleanup.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Fix all with cubic | Re-trigger cubic
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-lflag when$SHELLpoints atcshortcshFixes #12378
Validation
Summary by cubic
Skip the Unix login-shell flag for
csh/tcshto prevent command failures, while keeping login behavior for bash/zsh. Applies to both the core terminal tool and the CLI helper. Fixes #12378.-lforcsh/tcshon Unix/macOS and WSL; keep it for bash/zsh; Windows unchanged.getShellCommand.getShellCommandand add tests to verifycshbehavior.Written for commit 5f6ec1f. Summary will update on new commits. Review in cubic